Size Change: -31 B (0%)

Total Size: 1.39 MB

_{compressed-size-action}

@scruffian I looked at this again and saw this line:

// Also ensure other navigation menus have loaded so an
// accurate name can be created.

I assume we need all menus so when the menu name is created it isn't a duplicate? This would only be a factor however if the code in createNavigationMenu doesn't fetch all menus before creating the name.

Looking I can see that useGenerateDefaultNavigationTitle checks both draft and published menus so I don't see why we'd need this check.

Pinging @talldan as well because I feel like he might have written this component originally.

Noting also that we have some e2e test coverage for this functionality now. I guess we could amend that to prepopulate with a draft and a published menu and then assert that when inner blocks change only a single menu gets created and that it's title doesn't clash with the other ones.

I assume we need all menus so when the menu name is created it isn't a duplicate? This would only be a factor however if the code in createNavigationMenu doesn't fetch all menus before creating the name.

Looking I can see that useGenerateDefaultNavigationTitle checks both draft and published menus so I don't see why we'd need this check.

I think it's just because it has been refactored, and some dead code wasn't removed. In the past the menu creation/naming code was inside UnsavedInnerBlocks.

I wondering if we could change the resolution checker to check for both publish and draft? That way if the code in the useNavigationMenus hook ever stops requesting draft then this won't be able to run and the e2e test will fail.

The problem with the approach in this PR is that adding the page list as fallback ends up loading the unsaved inner blocks component which then ends up creating a wp_navigation menu. I think we should wait for #48698 to land and then reasses what we should do here...

is that adding the page list as fallback ends up loading the unsaved inner blocks component which then ends up creating a wp_navigation menu

I don't understand why that would happen. It should (and did!) happen like this:

• Add Nav Block with Page List as an inner block
• Nav block loads using UnControlled blocks component.
• No changes are detected so all is well.
• User makes some change to Page List (or Nav). Change detected.
• Menu Created.